From 19e792e67008629f91287072aa2beb708f2c3607 Mon Sep 17 00:00:00 2001 From: prtsie Date: Tue, 20 Aug 2024 17:09:30 +0300 Subject: [PATCH] Changed response of actions that create something to 200 OK --- .../SchengenVisaApi/Controllers/LocationsController.cs | 4 ++-- .../SchengenVisaApi/Controllers/UsersController.cs | 8 ++++---- .../Controllers/VisaApplicationController.cs | 4 ++-- 3 files changed, 8 insertions(+), 8 deletions(-) diff --git a/SchengenVisaApi/SchengenVisaApi/Controllers/LocationsController.cs b/SchengenVisaApi/SchengenVisaApi/Controllers/LocationsController.cs index da54637..35b7cb7 100644 --- a/SchengenVisaApi/SchengenVisaApi/Controllers/LocationsController.cs +++ b/SchengenVisaApi/SchengenVisaApi/Controllers/LocationsController.cs @@ -24,7 +24,7 @@ namespace SchengenVisaApi.Controllers /// Adds country with cities to DB /// Accessible only for [HttpPost] - [ProducesResponseType(StatusCodes.Status201Created)] + [ProducesResponseType(StatusCodes.Status200OK)] [ProducesResponseType(StatusCodes.Status400BadRequest)] [ProducesResponseType(StatusCodes.Status403Forbidden)] [ProducesResponseType(StatusCodes.Status401Unauthorized)] @@ -33,7 +33,7 @@ namespace SchengenVisaApi.Controllers public async Task AddCountry(AddCountryRequest request, CancellationToken cancellationToken) { await requestsHandler.AddCountryAsync(request, cancellationToken); - return Created(); + return Ok(); } } } diff --git a/SchengenVisaApi/SchengenVisaApi/Controllers/UsersController.cs b/SchengenVisaApi/SchengenVisaApi/Controllers/UsersController.cs index 217ea54..68fdb7a 100644 --- a/SchengenVisaApi/SchengenVisaApi/Controllers/UsersController.cs +++ b/SchengenVisaApi/SchengenVisaApi/Controllers/UsersController.cs @@ -15,19 +15,19 @@ namespace SchengenVisaApi.Controllers { /// Adds applicant with user account to DB [HttpPost] - [ProducesResponseType(StatusCodes.Status201Created)] + [ProducesResponseType(StatusCodes.Status200OK)] [ProducesResponseType(StatusCodes.Status409Conflict)] [Route("applicant")] public async Task Register(RegisterApplicantRequest request, CancellationToken cancellationToken) { await registerService.Register(request, cancellationToken); - return Created(); + return Ok(); } /// Adds approving authority with user account to DB /// Accessible only for [HttpPost] - [ProducesResponseType(StatusCodes.Status201Created)] + [ProducesResponseType(StatusCodes.Status200OK)] [ProducesResponseType(StatusCodes.Status409Conflict)] [ProducesResponseType(StatusCodes.Status403Forbidden)] [ProducesResponseType(StatusCodes.Status401Unauthorized)] @@ -36,7 +36,7 @@ namespace SchengenVisaApi.Controllers public async Task RegisterAuthority(RegisterRequest request, CancellationToken cancellationToken) { await registerService.RegisterAuthority(request, cancellationToken); - return Created(); + return Ok(); } /// Returns JWT-token for authentication diff --git a/SchengenVisaApi/SchengenVisaApi/Controllers/VisaApplicationController.cs b/SchengenVisaApi/SchengenVisaApi/Controllers/VisaApplicationController.cs index 31ac32a..ec8c627 100644 --- a/SchengenVisaApi/SchengenVisaApi/Controllers/VisaApplicationController.cs +++ b/SchengenVisaApi/SchengenVisaApi/Controllers/VisaApplicationController.cs @@ -48,7 +48,7 @@ public class VisaApplicationController(IVisaApplicationRequestsHandler visaAppli /// Adds new to DB /// Adds application for authorized applicant [HttpPost] - [ProducesResponseType(StatusCodes.Status201Created)] + [ProducesResponseType(StatusCodes.Status200OK)] [ProducesResponseType(StatusCodes.Status403Forbidden)] [ProducesResponseType(StatusCodes.Status401Unauthorized)] [ProducesResponseType(StatusCodes.Status404NotFound)] @@ -57,7 +57,7 @@ public class VisaApplicationController(IVisaApplicationRequestsHandler visaAppli { var userId = GetUserId(); await visaApplicationRequestsHandler.HandleCreateRequest(userId, request, cancellationToken); - return Created(); + return Ok(); } private Guid GetUserId() => Guid.Parse(HttpContext.User.Claims.First(c => c.Type == ClaimTypes.NameIdentifier).Value);