diff --git a/SchengenVisaApi/SchengenVisaApi/Controllers/UsersController.cs b/SchengenVisaApi/SchengenVisaApi/Controllers/UsersController.cs index 4ff4df4..fc10d47 100644 --- a/SchengenVisaApi/SchengenVisaApi/Controllers/UsersController.cs +++ b/SchengenVisaApi/SchengenVisaApi/Controllers/UsersController.cs @@ -22,7 +22,7 @@ public class UsersController( IValidator registerApplicantRequestValidator, IValidator authDataValidator) : ControllerBase { - /// Adds applicant with user account to DB + /// Adds applicant with user account [HttpPost("register")] [ProducesResponseType(StatusCodes.Status200OK)] [ProducesResponseType(StatusCodes.Status409Conflict)] @@ -35,7 +35,7 @@ public class UsersController( return Ok(); } - /// Adds approving authority with user account to DB + /// Adds approving authority with user account /// Accessible only for admins [HttpPost("authorities")] [ProducesResponseType(StatusCodes.Status200OK)] @@ -92,7 +92,7 @@ public class UsersController( return Ok(); } - /// Removes authority's account authentication data + /// Removes authority's account /// Accessible only for admins [HttpDelete("authorities/{authorityAccountId:guid}")] [ProducesResponseType(StatusCodes.Status200OK)] diff --git a/SchengenVisaApi/SchengenVisaApi/Controllers/VisaApplicationController.cs b/SchengenVisaApi/SchengenVisaApi/Controllers/VisaApplicationController.cs index 6bb5bac..b415f16 100644 --- a/SchengenVisaApi/SchengenVisaApi/Controllers/VisaApplicationController.cs +++ b/SchengenVisaApi/SchengenVisaApi/Controllers/VisaApplicationController.cs @@ -8,21 +8,21 @@ using SchengenVisaApi.Common; namespace SchengenVisaApi.Controllers; -/// Controller for +/// Controller for visa applications [ApiController] [Route("visaApplications")] public class VisaApplicationController( IVisaApplicationRequestsHandler visaApplicationRequestsHandler, IValidator visaApplicationCreateRequestValidator) : ControllerBase { - /// Returns pending applications from DB + /// Returns pending applications /// Accessible only for approving authorities [HttpGet("pending")] [ProducesResponseType>(StatusCodes.Status200OK)] [ProducesResponseType(StatusCodes.Status403Forbidden)] [ProducesResponseType(StatusCodes.Status401Unauthorized)] [Authorize(policy: PolicyConstants.ApprovingAuthorityPolicy)] - public async Task Get(CancellationToken cancellationToken) + public async Task GetPending(CancellationToken cancellationToken) { var result = await visaApplicationRequestsHandler.GetPendingAsync(cancellationToken); return Ok(result); @@ -30,20 +30,19 @@ public class VisaApplicationController( /// Returns all applications of one applicant /// Returns applications of authorized applicant - [HttpGet] + [HttpGet("ofApplicant")] [ProducesResponseType>(StatusCodes.Status200OK)] [ProducesResponseType(StatusCodes.Status403Forbidden)] [ProducesResponseType(StatusCodes.Status401Unauthorized)] [ProducesResponseType(StatusCodes.Status404NotFound)] [Authorize(policy: PolicyConstants.ApplicantPolicy)] - [Route("ofApplicant")] public async Task GetForApplicant(CancellationToken cancellationToken) { var result = await visaApplicationRequestsHandler.GetForApplicantAsync(cancellationToken); return Ok(result); } - /// Adds new application to DB + /// Adds new application /// Adds application for authorized applicant [HttpPost] [ProducesResponseType(StatusCodes.Status200OK)] @@ -52,7 +51,7 @@ public class VisaApplicationController( [ProducesResponseType(StatusCodes.Status404NotFound)] [ProducesResponseType(StatusCodes.Status400BadRequest)] [Authorize(policy: PolicyConstants.ApplicantPolicy)] - public async Task Create(VisaApplicationCreateRequest request, CancellationToken cancellationToken) + public async Task CreateApplication(VisaApplicationCreateRequest request, CancellationToken cancellationToken) { await visaApplicationCreateRequestValidator.ValidateAndThrowAsync(request, cancellationToken); @@ -62,28 +61,26 @@ public class VisaApplicationController( /// Sets application status to closed /// Accessible only for applicant - [HttpPatch] + [HttpPatch("{applicationId:guid}")] [ProducesResponseType(StatusCodes.Status200OK)] [ProducesResponseType(StatusCodes.Status403Forbidden)] [ProducesResponseType(StatusCodes.Status401Unauthorized)] [ProducesResponseType(StatusCodes.Status404NotFound)] [Authorize(policy: PolicyConstants.ApplicantPolicy)] - [Route("{applicationId:guid}")] public async Task CloseApplication(Guid applicationId, CancellationToken cancellationToken) { await visaApplicationRequestsHandler.HandleCloseRequestAsync(applicationId, cancellationToken); return Ok(); } - /// Allows approving authorities approve or reject applications + /// Approve or reject applications /// Accessible only for authorities - [HttpPatch] + [HttpPatch("approving/{applicationId:guid}")] [ProducesResponseType(StatusCodes.Status200OK)] [ProducesResponseType(StatusCodes.Status403Forbidden)] [ProducesResponseType(StatusCodes.Status401Unauthorized)] [ProducesResponseType(StatusCodes.Status404NotFound)] [Authorize(policy: PolicyConstants.ApprovingAuthorityPolicy)] - [Route("approving/{applicationId:guid}")] public async Task SetStatusFromAuthority(Guid applicationId, AuthorityRequestStatuses status, CancellationToken cancellationToken) { await visaApplicationRequestsHandler.SetApplicationStatusFromAuthorityAsync(applicationId, status, cancellationToken);